Rely on FAM for much of the foreman_provisioning setup#1888
Open
ekohl wants to merge 1 commit intotheforeman:masterfrom
Open
Rely on FAM for much of the foreman_provisioning setup#1888ekohl wants to merge 1 commit intotheforeman:masterfrom
ekohl wants to merge 1 commit intotheforeman:masterfrom
Conversation
ekohl
commented
Dec 3, 2024
Comment on lines
+13
to
+16
| 0: | ||
| type: network | ||
| network: provision | ||
| model: virtio |
Member
Author
There was a problem hiding this comment.
@evgeni this is taken from the examples in https://theforeman.github.io/foreman-ansible-modules/develop/plugins/compute_profile_module.html#ansible-collections-theforeman-foreman-compute-profile-module but the description says it's a list, so should it be
Suggested change
| 0: | |
| type: network | |
| network: provision | |
| model: virtio | |
| - type: network | |
| network: provision | |
| model: virtio |
| --- | ||
| # Make sure admin does not default to any taxonomy | ||
| - name: 'disable default context for admin' | ||
| # TODO: how to pass org and location IDs 0 to FAM? |
Member
Author
There was a problem hiding this comment.
I couldn't find this on https://theforeman.github.io/foreman-ansible-modules/develop/plugins/user_module.html#ansible-collections-theforeman-foreman-user-module and I'm wonder how this even works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't tested now and needs some proper review. I'll highlight some questions inline.